feat(button): circular icon button to appear round at minimum #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/feat
prudho
approved these changes
Jun 3, 2024
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever a
circular icon buttonwas used to reduce the padding but use text instead of an icon, the button does not appear as a circle at least (that is taken care of forcircular label)By adding a min width to a circular button this gets fixed.
I intentionally added the minwidth directly to
circular button(instead ofcircular icon button) as it saves an extra selector and the default min-width is already reached (because of the larger paddding) when a non icon button is used.Screenshot
Before
After
Testcase
Remove CSS to see issue
https://jsfiddle.net/lubber/do4tujhx/18/